config: remove possibility of nothing return from get_config#302
Merged
config: remove possibility of nothing return from get_config#302
nothing return from get_config#302Conversation
Our current configuration system uses `Configuration.Maybe` to distinguish between "no configuration set" and "user has set some configuration", essentially allowing each configuration to be represented as `nothing`. As a result, `get_config` is currently set up to potentially return `nothing`, but call sites throughout the codebase do not handle cases where `nothing` is returned. `get_config` is fundamentally used to retrieve some configuration value regardless of whether it is a default or not, and there is no need to return `nothing` in the first place. This commit fixes `get_config` to never return `nothing` in all cases using `DEFAULT_CONFIG`, resolving this logic error and type instability.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 69.14% 69.17% +0.03%
==========================================
Files 39 39
Lines 3915 3916 +1
==========================================
+ Hits 2707 2709 +2
+ Misses 1208 1207 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current configuration system uses
Configuration.Maybeto distinguish between "no configuration set" and "user has set some configuration", essentially allowing each configuration to be represented asnothing. As a result,get_configis currently set up to potentially returnnothing, but call sites throughout the codebase do not handle cases wherenothingis returned.get_configis fundamentally used to retrieve some configuration value regardless of whether it is a default or not, and there is no need to returnnothingin the first place.This commit fixes
get_configto never returnnothingin all cases usingDEFAULT_CONFIG, resolving this logic error and type instability.